Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b795d6eed76f130a043ab12fc3d9b6242f488e9
https://github.com/WebKit/WebKit/commit/5b795d6eed76f130a043ab12fc3d9b6242f488e9
Author: Chris Dumez <[email protected]>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M Source/WebCore/Modules/fetch/FetchResponse.cpp
M Source/WebCore/Modules/fetch/FetchResponse.h
M Source/WebCore/Modules/screen-wake-lock/WakeLock.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentInlines.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/ImageOverlay.cpp
M Source/WebCore/dom/mac/ImageControlsMac.cpp
M Source/WebCore/html/BaseDateAndTimeInputType.cpp
M Source/WebCore/html/HTMLProgressElement.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/HTMLTextFormControlElement.cpp
M Source/WebCore/html/ImageDocument.cpp
M Source/WebCore/html/RangeInputType.cpp
M Source/WebCore/html/TextFieldInputType.cpp
M Source/WebCore/html/track/VTTRegion.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/PageSerializer.cpp
M Source/WebCore/page/mac/ImageOverlayControllerMac.mm
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/style/RuleSetBuilder.cpp
M Source/WebCore/style/StyleResolveForDocument.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleScope.cpp
M Source/WebCore/svg/SVGUseElement.cpp
M Source/WebCore/xml/XMLHttpRequest.cpp
M Source/WebCore/xml/XMLHttpRequest.h
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Log Message:
-----------
Reduce use of protected functions in Source/WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=306694
Reviewed by Anne van Kesteren.
Adopt `protect()` at call sites instead.
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::consumeBodyReceivedByChunk):
(WebCore::FetchResponse::consumeBodyAsStream):
* Source/WebCore/Modules/fetch/FetchResponse.h:
* Source/WebCore/Modules/screen-wake-lock/WakeLock.cpp:
(WebCore::WakeLock::request):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::invalidateEventListenerRegions):
(WebCore::Document::fonts):
(WebCore::Document::protectedWakeLockManager): Deleted.
(WebCore::Document::protectedLoader const): Deleted.
(WebCore::Document::protectedFontSelector const): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::asyncNodeDeletionQueue):
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::fontSelector const):
(WebCore::Document::fontSelector): Deleted.
(WebCore::Document::protectedDocumentElement const): Deleted.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::protectedUserAgentShadowRoot const): Deleted.
(WebCore::Element::protectedClassList): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::isInsideOverlay):
(WebCore::ImageOverlay::isOverlayText):
* Source/WebCore/dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::isInsideImageControls):
* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::didChangeValueFromControl):
* Source/WebCore/html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress const):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
* Source/WebCore/html/ImageDocument.cpp:
(WebCore::ImageDocument::updateDuringParsing):
* Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::scrollTo const):
* Source/WebCore/page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* Source/WebCore/page/mac/ImageOverlayControllerMac.mm:
(WebCore::ImageOverlayController::updateDataDetectorHighlights):
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::glyphDataForCharacter const):
* Source/WebCore/platform/graphics/FontCascade.h:
(WebCore::FontCascade::primaryFont const):
(WebCore::FontCascade::fallbackRangesAt const):
(WebCore::FontCascade::isFixedPitch const):
(WebCore::FontCascade::canTakeFixedPitchFastContentMeasuring const):
(WebCore::FontCascade::protectedFontSelector const): Deleted.
* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver):
* Source/WebCore/style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::initialize):
* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::createDocumentResolver):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree const):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const):
(WebCore::SVGUseElement::transferEventListenersToShadowTree const):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::timeoutTimerFired):
(WebCore::XMLHttpRequest::LoadingActivity::protectedLoader const): Deleted.
* Source/WebCore/xml/XMLHttpRequest.h:
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::usePreload):
(WebKit::ServiceWorkerFetchTask::convertToDownload):
(WebKit::ServiceWorkerFetchTask::sendData):
(WebKit::ServiceWorkerFetchTask::protectedLoader const): Deleted.
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::addArchiveResource):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::innerText const):
Canonical link: https://commits.webkit.org/306616@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
