Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4d541ee463c91efb430ac662e09a7d4b5ff95be0
https://github.com/WebKit/WebKit/commit/4d541ee463c91efb430ac662e09a7d4b5ff95be0
Author: Chris Dumez <[email protected]>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M Source/WebCore/dom/ScriptExecutionContext.cpp
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/loader/WorkerThreadableLoader.cpp
M Source/WebCore/workers/ScriptBuffer.h
M Source/WebCore/workers/WorkerAnimationController.cpp
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebCore/workers/WorkerOrWorkletScriptController.cpp
M Source/WebCore/workers/WorkerOrWorkletScriptController.h
M Source/WebCore/workers/WorkerOrWorkletThread.cpp
M Source/WebCore/workers/WorkerOrWorkletThread.h
M Source/WebCore/workers/service/ServiceWorker.cpp
M Source/WebCore/workers/service/ServiceWorker.h
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
M Source/WebCore/workers/service/ServiceWorkerProvider.cpp
M Source/WebCore/workers/service/ServiceWorkerProvider.h
M Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp
M Source/WebCore/workers/service/context/SWContextManager.cpp
M Source/WebCore/workers/service/context/SWContextManager.h
M Source/WebCore/workers/service/server/SWScriptStorage.cpp
M Source/WebCore/workers/service/server/SWServer.cpp
M Source/WebCore/workers/service/server/SWServer.h
M Source/WebCore/workers/service/server/SWServerJobQueue.cpp
M Source/WebCore/workers/service/server/SWServerRegistration.cpp
M Source/WebCore/workers/service/server/SWServerRegistration.h
M Source/WebCore/workers/service/server/SWServerToContextConnection.cpp
M Source/WebCore/workers/service/server/SWServerToContextConnection.h
M Source/WebCore/workers/service/server/SWServerWorker.cpp
M Source/WebCore/workers/service/server/SWServerWorker.h
M Source/WebCore/workers/shared/context/SharedWorkerContextManager.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/WebProcess.cpp
Log Message:
-----------
Reduce use of protected functions in Source/WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=306743
Reviewed by Anne van Kesteren.
Adopt `protect()` at call sites instead.
* Source/WebCore/dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::registerServiceWorker):
(WebCore::ScriptExecutionContext::unregisterServiceWorker):
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::getContext):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::matchRegistration):
* Source/WebCore/loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
* Source/WebCore/workers/ScriptBuffer.h:
(WebCore::ScriptBuffer::bufferForSerialization const):
(WebCore::ScriptBuffer::protectedBuffer const): Deleted.
* Source/WebCore/workers/WorkerAnimationController.cpp:
(WebCore::WorkerAnimationController::scheduleAnimation):
(WebCore::WorkerAnimationController::animationTimerFired):
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::protectedSocketProvider): Deleted.
(WebCore::WorkerGlobalScope::protectedNavigator): Deleted.
(WebCore::WorkerGlobalScope::protectedPerformance const): Deleted.
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebCore/workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule):
(WebCore::WorkerOrWorkletScriptController::initScriptWithSubclass):
(WebCore::WorkerOrWorkletScriptController::protectedGlobalScope const): Deleted.
* Source/WebCore/workers/WorkerOrWorkletScriptController.h:
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::startRunningDebuggerTasks):
(WebCore::WorkerOrWorkletThread::runEventLoop):
(WebCore::WorkerOrWorkletThread::workerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::protectedGlobalScope const): Deleted.
* Source/WebCore/workers/WorkerOrWorkletThread.h:
(WebCore::WorkerOrWorkletThread::globalScope const):
* Source/WebCore/workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):
(WebCore::ServiceWorker::protectedSWConnection): Deleted.
* Source/WebCore/workers/service/ServiceWorker.h:
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):
* Source/WebCore/workers/service/ServiceWorkerProvider.cpp:
(WebCore::ServiceWorkerProvider::protectedServiceWorkerConnection): Deleted.
* Source/WebCore/workers/service/ServiceWorkerProvider.h:
* Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp:
(WebCore::ServiceWorkerWindowClient::focus):
(WebCore::ServiceWorkerWindowClient::navigate):
* Source/WebCore/workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::startedServiceWorker):
* Source/WebCore/workers/service/context/SWContextManager.h:
(WebCore::SWContextManager::protectedConnection const): Deleted.
* Source/WebCore/workers/service/server/SWScriptStorage.cpp:
(WebCore::SWScriptStorage::store):
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::Connection::startBackgroundFetch):
(WebCore::SWServer::Connection::backgroundFetchInformation):
(WebCore::SWServer::Connection::backgroundFetchIdentifiers):
(WebCore::SWServer::Connection::abortBackgroundFetch):
(WebCore::SWServer::Connection::matchBackgroundFetch):
(WebCore::SWServer::Connection::retrieveRecordResponse):
(WebCore::SWServer::Connection::retrieveRecordResponseBody):
(WebCore::SWServer::protectedBackgroundFetchEngine): Deleted.
* Source/WebCore/workers/service/server/SWServer.h:
* Source/WebCore/workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
* Source/WebCore/workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::activate):
* Source/WebCore/workers/service/server/SWServerRegistration.h:
(WebCore::SWServerRegistration::preInstallationWorker const):
(WebCore::SWServerRegistration::installingWorker const):
(WebCore::SWServerRegistration::waitingWorker const):
(WebCore::SWServerRegistration::activeWorker const):
(WebCore::SWServerRegistration::protectedPreInstallationWorker const): Deleted.
(WebCore::SWServerRegistration::protectedInstallingWorker const): Deleted.
(WebCore::SWServerRegistration::protectedWaitingWorker const): Deleted.
(WebCore::SWServerRegistration::protectedActiveWorker const): Deleted.
* Source/WebCore/workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::terminateWhenPossible):
(WebCore::SWServerToContextConnection::protectedServer const): Deleted.
* Source/WebCore/workers/service/server/SWServerToContextConnection.h:
* Source/WebCore/workers/service/server/SWServerWorker.cpp:
(WebCore::m_routes):
(WebCore::SWServerWorker::startTermination):
(WebCore::SWServerWorker::findClientByIdentifier const):
(WebCore::SWServerWorker::findClientByVisibleIdentifier):
(WebCore::SWServerWorker::matchAll):
(WebCore::SWServerWorker::userAgent const):
(WebCore::SWServerWorker::setState):
(WebCore::SWServerWorker::workerThreadMode const):
(WebCore::SWServerWorker::shouldBeTerminated const):
(WebCore::SWServerWorker::terminationIfPossibleTimerFired):
(WebCore::SWServerWorker::isClientActiveServiceWorker const):
(WebCore::SWServerWorker::protectedServer const): Deleted.
* Source/WebCore/workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::server const):
(WebCore::SWServerWorker::server): Deleted.
* Source/WebCore/workers/shared/context/SharedWorkerContextManager.h:
(WebCore::SharedWorkerContextManager::protectedConnection const): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):
Canonical link: https://commits.webkit.org/306617@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
