Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e4e4dc802f01766c75d9c9066c94c4b172f6bd29
https://github.com/WebKit/WebKit/commit/e4e4dc802f01766c75d9c9066c94c4b172f6bd29
Author: Aditya Keerthi <[email protected]>
Date: 2026-02-13 (Fri, 13 Feb 2026)
Changed paths:
M Source/WebKit/Shared/PDFDisplayMode.h
M Source/WebKit/UIProcess/ios/WKContentView.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
Log Message:
-----------
Refactor logic to check PDF display modes
https://bugs.webkit.org/show_bug.cgi?id=307764
rdar://170298190
Reviewed by Abrar Rahman Protyasha.
Move helper methods to WebKit/Shared, since they will be used in both UI and Web
process code.
Deploy helper methods in UI process code instead of checking against specific
display modes.
* Source/WebKit/Shared/PDFDisplayMode.h:
(WebKit::isSinglePagePDFDisplayMode):
(WebKit::isTwoUpPDFDisplayMode):
(WebKit::isScrollingPDFDisplayMode):
(WebKit::isDiscretePDFDisplayMode):
* Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _updatePDFDisplayModeForHorizontalSizeClassChangeIfNeeded]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteractionWithDataDetectors:]):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::supportsDisplayMode const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
(WebKit::PDFDocumentLayout::isSinglePageDisplayMode const):
(WebKit::PDFDocumentLayout::isTwoUpDisplayMode const):
(WebKit::PDFDocumentLayout::isScrollingDisplayMode const):
(WebKit::PDFDocumentLayout::isDiscreteDisplayMode const):
(WebKit::PDFDocumentLayout::isSinglePageDisplayMode): Deleted.
(WebKit::PDFDocumentLayout::isTwoUpDisplayMode): Deleted.
(WebKit::PDFDocumentLayout::isScrollingDisplayMode): Deleted.
(WebKit::PDFDocumentLayout::isDiscreteDisplayMode): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm:
(WebKit::PDFPresentationController::createForMode):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::supportsDisplayMode const):
Canonical link: https://commits.webkit.org/307480@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
