Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1fc35e3d7b6af09d1dca2ad0f83c672d094ac4f4
https://github.com/WebKit/WebKit/commit/1fc35e3d7b6af09d1dca2ad0f83c672d094ac4f4
Author: Anne van Kesteren <[email protected]>
Date: 2026-02-24 (Tue, 24 Feb 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/input-element-pseudo-open-click.optional-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/input-element-pseudo-open-click.optional.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/input-element-pseudo-open.optional-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/input-element-pseudo-open.optional.html
M LayoutTests/platform/ios/TestExpectations
A
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-pseudo/input-element-pseudo-open.optional-expected.txt
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/html/BaseDateAndTimeInputType.cpp
M Source/WebCore/html/BaseDateAndTimeInputType.h
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/ColorInputType.h
M Source/WebCore/html/TextFieldInputType.cpp
M Source/WebCore/html/TextFieldInputType.h
Log Message:
-----------
Implement :open for <input>
https://bugs.webkit.org/show_bug.cgi?id=307798
Reviewed by Aditya Keerthi.
Re-implement isPresentingAttachedView() in terms of m_popupIsVisible
tracked by TextFieldInputType, ColorInputType, and
BaseDateAndTimeInputType as the original approach did not work
correctly.
For instance, <input type=color> has two pickers. An initial picker and
a platform picker. When the initial picker is closed endColorChooser()
is called. When the platform picker is closed, didEndChooser(). But
never both. The code however assumed the latter would always be called.
There's also an issue with the existing test-only showPicker()
implementation, which is that it does not focus the elements. This
means that they can also not be blurred and the picker ends up being
hard to close. For this reason we add new web-platform-tests coverage
for the non-showPicker() case so :open can be adequately tested.
We also clean up these classes a tiny bit while here.
Tests:
https://github.com/web-platform-tests/wpt/pull/57990
Canonical link: https://commits.webkit.org/308148@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
