Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 364d59a33f8d796765c368531aa4e28afb23d42d
https://github.com/WebKit/WebKit/commit/364d59a33f8d796765c368531aa4e28afb23d42d
Author: Chris Dumez <[email protected]>
Date: 2026-02-24 (Tue, 24 Feb 2026)
Changed paths:
M Source/WebCore/Modules/gamepad/GamepadManager.cpp
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
M Source/WebCore/Modules/permissions/Permissions.cpp
M Source/WebCore/Modules/webaudio/AudioContext.cpp
M Source/WebCore/dom/DOMImplementation.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/VisitedLinkState.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/SelectionGeometryGatherer.cpp
M Source/WebCore/history/CachedPage.cpp
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/HistoryController.cpp
M Source/WebCore/loader/NavigationScheduler.cpp
M Source/WebCore/loader/PolicyChecker.cpp
M Source/WebCore/loader/SubframeLoader.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
M Source/WebCore/page/scrolling/mac/ScrollerPairMac.h
M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/WebProcess/Inspector/PageInspectorTarget.cpp
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm
M Source/WebKitLegacy/WebCoreSupport/LegacyWebPageDebuggable.cpp
M Source/WebKitLegacy/WebCoreSupport/LegacyWebPageInspectorController.cpp
Log Message:
-----------
Reduce use of protected functions in Source/WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=308523
Reviewed by Charlie Wolfe.
* Source/WebCore/Modules/gamepad/GamepadManager.cpp:
(WebCore::navigatorGamepadFromDOMWindow):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::mediaSession const):
* Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::allow):
* Source/WebCore/Modules/permissions/Permissions.cpp:
(WebCore::determineGeolocationPermissionState):
* Source/WebCore/Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::nowPlayingInfo const):
* Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::processCaptureStateDidChange):
(WebCore::Document::voiceActivityDetected):
* Source/WebCore/dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers):
* Source/WebCore/editing/SelectionGeometryGatherer.cpp:
(WebCore::SelectionGeometryGatherer::Notifier::~Notifier):
* Source/WebCore/history/CachedPage.cpp:
(WebCore::CachedPage::restoreNavigationAPIHistoryItems):
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::mediaSession const):
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::getContext):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::stopForUserCancel):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::dispatchNavigateEvent):
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::addVisitedLink):
* Source/WebCore/loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigationByKey::findBackForwardItemByKey const):
* Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::findPluginMIMETypeFromURL):
(WebCore::logPluginRequest):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::protectedNavigation): Deleted.
(WebCore::LocalDOMWindow::protectedNavigator): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::updateNavigationEntry):
(WebCore::Navigation::disposeOfForwardEntriesInParents):
(WebCore::Navigation::recursivelyDisposeOfForwardEntriesInParents):
* Source/WebCore/page/Page.cpp:
(WebCore::m_mediaSessionManagerFactory):
(WebCore::Page::~Page):
(WebCore::Page::updateTopDocumentSyncData):
(WebCore::Page::setVisitedLinkStore):
(WebCore::Page::startMonitoringWheelEvents):
(WebCore::Page::didChangeMainDocument):
(WebCore::Page::protectedPluginData): Deleted.
(WebCore::Page::protectedTopDocumentSyncData const): Deleted.
(WebCore::Page::protectedUserContentProviderForFrame): Deleted.
(WebCore::Page::protectedVisitedLinkStore): Deleted.
(WebCore::Page::protectedScrollLatchingController): Deleted.
(WebCore::Page::protectedImageOverlayController): Deleted.
(WebCore::Page::protectedImageAnalysisQueue): Deleted.
(WebCore::Page::protectedInspectorController): Deleted.
(WebCore::Page::protectedServicesOverlayController): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::inspectorController):
(WebCore::Page::servicesOverlayController):
(WebCore::Page::userContentProviderForFrame):
* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::visibilityChanged):
(WebCore::ScrollerMac::updateMinimumKnobLength):
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.h:
(WebCore::ScrollerPairMac::node const):
(WebCore::ScrollerPairMac::protectedNode const): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm:
(WebCore::ScrollerPairMac::mouseEnteredContentArea):
(WebCore::ScrollerPairMac::mouseExitedContentArea):
* Source/WebCore/testing/Internals.cpp:
(WebCore::InspectorStubFrontend::InspectorStubFrontend):
(WebCore::InspectorStubFrontend::closeWindow):
* Source/WebKit/WebProcess/Inspector/PageInspectorTarget.cpp:
(WebKit::PageInspectorTarget::connect):
(WebKit::PageInspectorTarget::disconnect):
(WebKit::PageInspectorTarget::sendMessageToTargetBackend):
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::load):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::objectContentType):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::startVisualTranslation):
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::setMediaSessionAndRegisterAsObserver):
* Source/WebKitLegacy/WebCoreSupport/LegacyWebPageDebuggable.cpp:
(LegacyWebPageDebuggable::setIndicating):
* Source/WebKitLegacy/WebCoreSupport/LegacyWebPageInspectorController.cpp:
Canonical link: https://commits.webkit.org/308149@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
