Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a328af507417446269a93bb77daae6d5aeb9bd6f
https://github.com/WebKit/WebKit/commit/a328af507417446269a93bb77daae6d5aeb9bd6f
Author: Ben Nham <[email protected]>
Date: 2026-02-26 (Thu, 26 Feb 2026)
Changed paths:
M Source/WebKit/Configurations/BaseXPCService.xcconfig
A Source/WebKit/Configurations/RelocatableFrameworksLinkerFlags.xcconfig
M Source/WebKit/Configurations/webpushd.xcconfig
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
STP webpushd-relocatable links the wrong WebKit
https://bugs.webkit.org/show_bug.cgi?id=308558
rdar://170101535
Reviewed by Elliott Williams.
The webpushd-relocatable executable in Safari Technology Preview is linking
against the system
WebKit rather than STP's WebKit. This causes Web Push failures in STP.
To fix this, move the relocatable framework logic that sets DYLD_FRAMEWORK_PATH
and related env vars
out of BaseXPCService.xcconfig in to RelocatableFrameworksLinkerFlags.xcconfig.
Then both
BaseXPCService.xcconfig and webpushd.xcconfig can include that config file and
set
WK_PATH_FROM_SERVICE_EXECUTABLE_TO_FRAMEWORK to the appropriate values.
Additionally, webpushd-relocatable doesn't have the proper APS entitlements.
Give it those
entitlements.
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/RelocatableFrameworksLinkerFlags.xcconfig: Added.
* Source/WebKit/Configurations/webpushd.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/308306@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
