Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d18b599be780e422898f409e77b8f08427cbda8f
https://github.com/WebKit/WebKit/commit/d18b599be780e422898f409e77b8f08427cbda8f
Author: Wenson Hsieh <[email protected]>
Date: 2026-02-26 (Thu, 26 Feb 2026)
Changed paths:
A
LayoutTests/fast/text-extraction/debug-text-extraction-covered-button-expected.txt
A LayoutTests/fast/text-extraction/debug-text-extraction-covered-button.html
M LayoutTests/fast/text-extraction/debug-text-extraction-form-controls.html
A
LayoutTests/fast/text-extraction/debug-text-extraction-offscreen-button-expected.txt
A
LayoutTests/fast/text-extraction/debug-text-extraction-offscreen-button.html
A
LayoutTests/fast/text-extraction/debug-text-extraction-select-options-expected.txt
A LayoutTests/fast/text-extraction/debug-text-extraction-select-options.html
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebKit/Shared/TextExtractionToStringConversion.cpp
M Source/WebKit/Shared/TextExtractionToStringConversion.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.mm
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm
Log Message:
-----------
[AutoFill Debugging] Add a way for clients to include/exclude select options
https://bugs.webkit.org/show_bug.cgi?id=308771
rdar://171291215
Reviewed by Abrar Rahman Protyasha.
Add support for a new property to control whether individual `select` options
should be included.
See below for more details.
Tests: fast/text-extraction/debug-text-extraction-covered-button.html
fast/text-extraction/debug-text-extraction-offscreen-button.html
fast/text-extraction/debug-text-extraction-select-options.html
*
LayoutTests/fast/text-extraction/debug-text-extraction-covered-button-expected.txt:
Added.
* LayoutTests/fast/text-extraction/debug-text-extraction-covered-button.html:
Added.
* LayoutTests/fast/text-extraction/debug-text-extraction-form-controls.html:
*
LayoutTests/fast/text-extraction/debug-text-extraction-offscreen-button-expected.txt:
Added.
* LayoutTests/fast/text-extraction/debug-text-extraction-offscreen-button.html:
Added.
*
LayoutTests/fast/text-extraction/debug-text-extraction-select-options-expected.txt:
Added.
* LayoutTests/fast/text-extraction/debug-text-extraction-select-options.html:
Added.
Add tests to cover the behavior changes in this patch.
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::dispatchSimulatedClick):
Drive-by fix: also flip this returned value to the completion handler, so that
we indicate failure
when the element is disabled or the click fails, not vice versa.
* Source/WebKit/Shared/TextExtractionToStringConversion.cpp:
(WebKit::TextExtractionAggregator::includeSelectOptions const):
(WebKit::populateJSONForItem):
(WebKit::addPartsForItem):
* Source/WebKit/Shared/TextExtractionToStringConversion.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView
_extractDebugTextWithConfigurationWithoutUpdatingFilterRules:assertionScope:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.mm:
(-[_WKTextExtractionConfiguration _initForOnlyVisibleText:]):
(-[_WKTextExtractionConfiguration setIncludeSelectOptions:]):
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
* Tools/TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp:
(WTR::toTextExtractionTestOptions):
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::createTextExtractionConfiguration):
Canonical link: https://commits.webkit.org/308307@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
