[webkit-changes] [WebKit/WebKit] cfa5a1: REGRESSION(294844@main): svg/filters/feTile.svg is...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfa5a1badcde481945df422fe62cd1abab721b3e
      
https://github.com/WebKit/WebKit/commit/cfa5a1badcde481945df422fe62cd1abab721b3e
  Author: Simon Fraser <simon.fra...@apple.com>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/reference/svg-filter-gradient-interpolation-ref.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-filter-gradient-interpolation-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-filter-gradient-interpolation.html
    M Source/WebCore/platform/graphics/Gradient.h
    M Source/WebCore/platform/graphics/cg/GradientCG.cpp
    M Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp
    M Source/WebCore/platform/graphics/cg/GradientRendererCG.h

  Log Message:
  -----------
  REGRESSION(294844@main): svg/filters/feTile.svg is broken
https://bugs.webkit.org/show_bug.cgi?id=305066
rdar://167786547

Reviewed by Matt Woodrow.

294844@main added caching of colors in gradients after converting to the 
destination colorspace, for performance.
However, this means that the gradient colors are now going to be interpolated 
in that destination space,
which gives in correct results, especially for linearRGB as used in filters. So 
revert the change, but add
tests.

Tests: 
imported/w3c/web-platform-tests/css/filter-effects/reference/svg-filter-gradient-interpolation-ref.html
       
imported/w3c/web-platform-tests/css/filter-effects/svg-filter-gradient-interpolation.html

* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/reference/svg-filter-gradient-interpolation-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-filter-gradient-interpolation-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-filter-gradient-interpolation.html:
 Added.
* Source/WebCore/platform/graphics/Gradient.h:
* Source/WebCore/platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::paint):
* Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp:
(WebCore::GradientRendererCG::GradientRendererCG):
(WebCore::GradientRendererCG::pickStrategy const):
(WebCore::GradientRendererCG::makeGradient const):
(WebCore::GradientRendererCG::colorSpace const): Deleted.
(WebCore::getResolvedColorComponentsInColorSpace): Deleted.
* Source/WebCore/platform/graphics/cg/GradientRendererCG.h:

Canonical link: https://commits.webkit.org/309060@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications