Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 55ffc93c06b7419bd505be5473ab6848b4a22061
https://github.com/WebKit/WebKit/commit/55ffc93c06b7419bd505be5473ab6848b4a22061
Author: Pascoe <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
Log Message:
-----------
Fix iterator invalidation crash in
StyleOriginatedTimelinesController::styleableWasRemoved
https://bugs.webkit.org/show_bug.cgi?id=309632
rdar://172219384
Reviewed by Antoine Quint.
attachAnimation() calls setTimeline() → setTimelineInternal() →
removeAnimation(*this),
which mutates the ListHashSet being iterated, invalidating the iterator and
causing
EXC_BAD_ACCESS when copying the next Ref.
Snapshot the animations into a Vector before iterating, same pattern used in
AnimationTimelinesController.cpp:150.
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::styleableWasRemoved):
Canonical link: https://commits.webkit.org/309061@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
