Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 146f78dd99b1f714ecc8b7f90ad3d494a8e401b8
https://github.com/WebKit/WebKit/commit/146f78dd99b1f714ecc8b7f90ad3d494a8e401b8
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-03-19 (Thu, 19 Mar 2026)
Changed paths:
M Source/WebKit/Modules/Internal/module.modulemap
R Source/WebKit/UIProcess/Cocoa/NSGlassEffectView+Extras.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
REGRESSION(309546@main): [macOS] UI process crashes when loading PDF files
(unrecognized selector `setUsesDefaultConfiguration:`)
https://bugs.webkit.org/show_bug.cgi?id=310275
rdar://172909794
Reviewed by Richard Robinson.
While 309546@main made the `usesDefaultConfiguration` property _visible_
to WKPDFHUDView.swift, we failed to provide the definition, which is
available in NSGlassEffectView+Extras.swift. This caused a runtime crash
when setting up WKPDFHUDView because NSGlassEffectView instances did not
respond to `setUsesDefaultConfiguration:`.
Additionally, the property declaration from the earlier fix is only
necessary for ObjC callers.
Instead, in this patch, we add NSGlassEffectView+Extras.swift as a
derived source under the build products directory in our Xcode project.
Plus, we entirely revert 309546@main since we do not have any ObjC users
of the usesDefaultConfiguration property.
* Source/WebKit/Modules/Internal/module.modulemap:
* Source/WebKit/UIProcess/Cocoa/NSGlassEffectView+Extras.h: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/309563@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
