Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7f536a3cf758a55ddb632e18fec8a217a31e8c92
https://github.com/WebKit/WebKit/commit/7f536a3cf758a55ddb632e18fec8a217a31e8c92
Author: Basuke Suzuki <[email protected]>
Date: 2026-03-19 (Thu, 19 Mar 2026)
Changed paths:
M Source/WebCore/history/HistoryItem.cpp
M Source/WebKit/Shared/WebBackForwardListItem.cpp
M Source/WebKit/Shared/WebBackForwardListItem.h
Log Message:
-----------
Remove unused WebBackForwardListItem::itemIsInSameDocument()
https://bugs.webkit.org/show_bug.cgi?id=310283
rdar://172617337
Reviewed by Brady Eidson.
WebBackForwardListItem::itemIsInSameDocument() in
Source/WebKit/Shared/WebBackForwardListItem.cpp has no callers since commit
2ede4615af7a (bug 260636, rdar://114351057) removed its only usage in
WebPageProxy::goToBackForwardItem().
The method compared mainFrameState().documentSequenceNumber between two
WebBackForwardListItems, but it was only used to decide whether to create a
Navigation object during back/forward navigation. That conditional was removed
and Navigation objects are now always created.
No new tests because this method is not used.
* Source/WebCore/history/HistoryItem.cpp:
(WebCore::HistoryItem::shouldDoSameDocumentNavigationTo const):
* Source/WebKit/Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::itemIsInSameDocument const): Deleted.
* Source/WebKit/Shared/WebBackForwardListItem.h:
Canonical link: https://commits.webkit.org/309564@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
