Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 749560aa559c3bf2c97f9bdf41ad8fddd0b8b24f
https://github.com/WebKit/WebKit/commit/749560aa559c3bf2c97f9bdf41ad8fddd0b8b24f
Author: Geoffrey Garen <[email protected]>
Date: 2026-05-24 (Sun, 24 May 2026)
Changed paths:
M Source/WebInspectorUI/CMakeLists.txt
Log Message:
-----------
[CMake] WebInspectorUI rebuilds when you touch any JavaScriptCore .cpp file
https://bugs.webkit.org/show_bug.cgi?id=315434
<rdar://problem/177794004>
Reviewed by David Kilzer.
Touching any JSC/WTF/bmalloc .cpp file re-runs copy-user-interface-resources.pl
(~1.3s). 313182@main made this worse on Mac by adding a copy_directory step
(~0.4s).
`ninja -d explain` shows the chain:
JavaScriptCore.framework/Versions/A/JavaScriptCore is dirty
-> WebInspectorUI/DerivedSources/.../InspectorBackendCommands.js is dirty
-> inspector-resources.stamp is dirty
* Source/WebInspectorUI/CMakeLists.txt: Don't depend on JavaScriptCore because
we only actually depend on InspectorBackendCommands.js, which we already
declare.
Also, when we copy, only copy-if-different. A byte-identical .js file has
no effect on WebInspector behavior. (I'm not sure if this case can happen
anymore, now that we've dropped the over-zealous dependency. But it's good
hygiene.)
Canonical link: https://commits.webkit.org/313812@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
