Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abcaf42866b178759f81eff6c290522c6e678520
      
https://github.com/WebKit/WebKit/commit/abcaf42866b178759f81eff6c290522c6e678520
  Author: Ryosuke Niwa <[email protected]>
  Date:   2026-05-24 (Sun, 24 May 2026)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/WKWebViewMacEditingTests.mm

  Log Message:
  -----------
  Google Docs: Typing in "Hindi - InScript" can result in an unexpected beep
https://bugs.webkit.org/show_bug.cgi?id=315421
rdar://177643899

Reviewed by Wenson Hsieh.

The bug was caused by the missing check for defaultPrevented and defaultHandled 
for keypress event
when we take an early exit.

Test: 
TestWebKitAPI.WKWebViewMacEditingTests.HindiInScriptViramaConjunctReportsKeystrokeHandled

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/WKWebViewMacEditingTests.mm:
(-[KeyableBorderlessWindow canBecomeKeyWindow]):
(-[KeyableBorderlessWindow unhandledKeyDownCount]):
(-[KeyableBorderlessWindow noResponderFor:]):
(TestWebKitAPI::TEST(WKWebViewMacEditingTests, 
HindiInScriptViramaConjunctReportsKeystrokeHandled)):

Canonical link: https://commits.webkit.org/313813@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to