Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce339f1f945495de5e02bce5929072856341abab
https://github.com/WebKit/WebKit/commit/ce339f1f945495de5e02bce5929072856341abab
Author: Chris Dumez <[email protected]>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
Log Message:
-----------
Fix inverted condition in WebSWServerToContextConnection::workerTerminated
https://bugs.webkit.org/show_bug.cgi?id=316523
Reviewed by Youenn Fablet.
The condition guarding the EndServiceWorkerBackgroundProcessing message
was missing a `!`, so the message was sent on every decrement of
m_processingFunctionalEventCount *except* when the count reached zero —
the exact opposite of every other End-Background-Processing site in the
same file (firePushEvent, fireNotificationEvent, fireBackgroundFetchEvent,
fireBackgroundFetchClickEvent).
As a result, the background-processing assertion held while terminating
a service worker was never released for the last in-flight functional
event, while spurious End messages were sent during normal counting.
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::workerTerminated):
Canonical link: https://commits.webkit.org/314728@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
