Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b6b264b578ac084adf8ed361d29e8fa90d7e3ae
https://github.com/WebKit/WebKit/commit/1b6b264b578ac084adf8ed361d29e8fa90d7e3ae
Author: Chris Dumez <[email protected]>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp
Log Message:
-----------
Fix unused constructor parameter in ServiceWorkerNavigationPreloader
https://bugs.webkit.org/show_bug.cgi?id=316522
Reviewed by Youenn Fablet.
The constructor parameter was misspelled `shouldCaptureExtraNetworkLoadMetric`
(missing trailing 's'), so the member initializer
`m_shouldCaptureExtraNetworkLoadMetrics(shouldCaptureExtraNetworkLoadMetrics())`
silently called the same-named getter — which returns the member's default-
initialized value (false) — instead of using the parameter. As a result,
`m_shouldCaptureExtraNetworkLoadMetrics` was always false regardless of what
callers passed, and additional network load metrics were never collected for
service worker navigation preload requests.
Rename the parameter to match the header declaration and use it directly in
the initializer.
*
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:
(WebKit::ServiceWorkerNavigationPreloader::ServiceWorkerNavigationPreloader):
Canonical link: https://commits.webkit.org/314729@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
