Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1286c5a040abcabc4ee93a846d81b3d5ded60649
      
https://github.com/WebKit/WebKit/commit/1286c5a040abcabc4ee93a846d81b3d5ded60649
  Author: Ryan Haddad <[email protected]>
  Date:   2026-06-16 (Tue, 16 Jun 2026)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [EWS] Don't forward tester OS/SDK as builder properties when re-triggering 
parent build
https://bugs.webkit.org/show_bug.cgi?id=317036
rdar://problem/179521390

Reviewed by Aakash Jain.

When a tester re-triggers the parent archive build after an infrastructure 
issue,
propertiesToPassToTriggers was forwarding the tester's own os_version / 
xcode_version
/ deployment_target values. If the re-triggered parent landed on a worker with 
a different
OS (which is expected for back-deployed macOS versions), the ConfigureBuild 
step compared
the new builder's actual OS against the forwarded tester values and failed the 
build with
"Error: OS/SDK version mismatch".

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers): Skip passing those three properties when 
self.triggers
is set, which is only true on the tester->parent re-trigger path.
* Tools/CISupport/ews-build/steps_unittest.py: Add new unit test.

Canonical link: https://commits.webkit.org/315296@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to