Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d262f2e6edc652e4d44bcd3fd3e6e706ff3aa7ef
https://github.com/WebKit/WebKit/commit/d262f2e6edc652e4d44bcd3fd3e6e706ff3aa7ef
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-17 (Wed, 17 Jun 2026)
Changed paths:
A LayoutTests/media/media-session-artwork-sizes-selection-expected.txt
A LayoutTests/media/media-session-artwork-sizes-selection.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediasession/MediaMetadata.cpp
Log Message:
-----------
MediaMetadata artwork "sizes" parsing reads the wrong substring for height
https://bugs.webkit.org/show_bug.cgi?id=317041
rdar://179523057
Reviewed by Jean-Yves Avenard.
For a "WxH" size token the height was parsed with element.right(posX) (the
rightmost posX
characters) rather than element.substring(posX + 1) (everything after the 'x').
The two coincide
only for square sizes; e.g. "1280x720" failed to parse and "50x100" yielded
height 0. Use
substring(posX + 1).
Test: media/media-session-artwork-sizes-selection.html
* LayoutTests/media/media-session-artwork-sizes-selection-expected.txt: Added.
* LayoutTests/media/media-session-artwork-sizes-selection.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::MediaMetadata::refreshArtworkImage):
Canonical link: https://commits.webkit.org/315402@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
