Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b0e1708f1a65643898b96480da8f3854e8b197ac
https://github.com/WebKit/WebKit/commit/b0e1708f1a65643898b96480da8f3854e8b197ac
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-17 (Wed, 17 Jun 2026)
Changed paths:
A
LayoutTests/media/picture-in-picture/picture-in-picture-api-shadow-root-element-expected.txt
A
LayoutTests/media/picture-in-picture/picture-in-picture-api-shadow-root-element.html
M
Source/WebCore/Modules/pictureinpicture/DocumentOrShadowRootPictureInPicture.cpp
Log Message:
-----------
pictureInPictureElement getter inverts the shadow-host connectivity check
https://bugs.webkit.org/show_bug.cgi?id=317104
rdar://179675087
Reviewed by Jean-Yves Avenard.
This should return null when the shadow root's host is NOT connected, but the
code returned null
when the host is connected, so the getter returned the wrong result for shadow
roots (null for the
normal connected case).
Test: media/picture-in-picture/picture-in-picture-api-shadow-root-element.html
*
LayoutTests/media/picture-in-picture/picture-in-picture-api-shadow-root-element-expected.txt:
Added.
*
LayoutTests/media/picture-in-picture/picture-in-picture-api-shadow-root-element.html:
Added.
*
Source/WebCore/Modules/pictureinpicture/DocumentOrShadowRootPictureInPicture.cpp:
(WebCore::DocumentOrShadowRootPictureInPicture::pictureInPictureElement):
Canonical link: https://commits.webkit.org/315403@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
