Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dbb0c0cd1d45afda1de7c1485b6e118c34086d2d
https://github.com/WebKit/WebKit/commit/dbb0c0cd1d45afda1de7c1485b6e118c34086d2d
Author: Ruthvik Konda <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/types/pointer-expected.txt
M Source/WebGPU/WGSL/TypeCheck.cpp
M Tools/TestWebKitAPI/Tests/WGSL/TypeCheckingTests.mm
Log Message:
-----------
[WGSL] shader,validation,types,pointer:access_mode:* is failing
https://bugs.webkit.org/show_bug.cgi?id=317960
rdar://180753798
Reviewed by Mike Wyrzykowski.
The <storage> address space only supports the read and read_write access modes,
so a
pointer type such as ptr<storage, u32, write> must be rejected. The pointer type
constructor parsed the access mode but did not reject write; reject it there,
matching
the validation already applied to variable declarations.
*
LayoutTests/http/tests/webgpu/webgpu/shader/validation/types/pointer-expected.txt:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::declareBuiltins):
* Tools/TestWebKitAPI/Tests/WGSL/TypeCheckingTests.mm:
(TestWGSLAPI::TEST(WGSLTypeCheckingTests, PointerAccessMode)):
Canonical link: https://commits.webkit.org/316029@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
