Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59ff2db194f5065cea86cadd6229c9b36999c2c7
https://github.com/WebKit/WebKit/commit/59ff2db194f5065cea86cadd6229c9b36999c2c7
Author: Sammy Gill <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M Tools/Scripts/webkitpy/api_tests/allowlist.txt
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/UIWKInteractionViewProtocol.mm
Log Message:
-----------
Add some dictation tests post 316049@main.
https://bugs.webkit.org/show_bug.cgi?id=318128
rdar://180951143
Reviewed by Abrar Rahman Protyasha.
We had some ideas for dictation tests to help increase our overall
coverage for this area, but unfortunately they did not land as part of
316049@main since it got merged before I was able to get to it and add
the tests. This is just a follow up to help add the discussed tests as
well as some additional ones to just reinforce our changes.
Also go through a couple of places and adopt RetainPtr where possible.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/UIWKInteractionViewProtocol.mm:
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
TextInteractionCanBeginInExistingSelection)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextContainingEmojis)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
SuppressSelectionChangesDuringDictation)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextStartsComposition)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextContinuesComposition)):
Updated this test so that the dictated content is a little longer which
may be a bit more representative of actual use.
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextClearingEmitsCompositionEnd)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextReplacesSelectedText)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextReplacesSelectedPortion)):
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextReplacesMultiWordSelection)):
Make sure that dictation still occurs as expected if the user already
had a selection in different scenarios.
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextEmitsCompositionEventSequence)):
Make sure that we get full order of composition events as expected
with a start event, multiple updates, and a final end event. Previous
tests were really only checking a subset of the expected events.
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextPreservesSurroundingText)):
Simple one just to make sure that we get the text as expected if
dictation starts in the middle of some content.
(TestWebKitAPI::TEST(UIWKInteractionViewProtocol,
ReplaceDictatedTextHandlesShrinkingHypothesis)):
It is possible for a subsequent hypothesis to be shorter than the
previous one.
Canonical link: https://commits.webkit.org/316110@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
