Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25db7a2d394b2a850d56037f38de03fd0181fb87
https://github.com/WebKit/WebKit/commit/25db7a2d394b2a850d56037f38de03fd0181fb87
Author: Ahmad Saleem <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M Source/WebCore/rendering/RenderLayerBacking.cpp
Log Message:
-----------
Remove duplicate (&layer == &m_owningLayer) condition in
RenderLayerBacking::paintIntoLayer
https://bugs.webkit.org/show_bug.cgi?id=318153
rdar://180962809
Reviewed by Nikolas Zimmermann and Simon Fraser.
paintOneLayer() evaluated `&layer == &m_owningLayer` twice back-to-back: once
to conditionally assign svgPaintOrderItemRange, and again to open the block
that actually consumes it. The std::optional was declared in the outer scope
solely to bridge the two checks.
svgPaintOrderItemRange is only read inside the second block (the
paintLayerContents() calls), so fold the assignment into that block and scope
the variable there. This evaluates the condition once and narrows the
variable's lifetime. No change in behavior.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
Canonical link: https://commits.webkit.org/316111@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
