Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a20a3d21098d9e1fcf0bfbcb5f6133847781a77
https://github.com/WebKit/WebKit/commit/6a20a3d21098d9e1fcf0bfbcb5f6133847781a77
Author: Said Abou-Hallawa <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/platform/graphics/ImageBufferDisplayListBackend.h
M Source/WebCore/platform/graphics/cg/ImageBufferCGPDFDocumentBackend.h
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
Log Message:
-----------
putPixelBuffer() and getPixelBuffer() should never be called for PDF and
DisplayList ImageBufferBackends
https://bugs.webkit.org/show_bug.cgi?id=312835
rdar://174740190
Reviewed by Simon Fraser.
Currently these functions debug ASSERT only. In the release build,
getPixelBuffer()
returns without filling the PixelBuffer with zeros. If the ImageBuffer is
remote,
the returned PixelBuffer will be serialized uninitialized to the WebProcess.
RemoteImageBuffer should MESSAGE_CHECK, the backend has pixels. The calls to
putPixelBuffer() and getPixelBuffer() should not be made in normal snapshotting
scenarios.
* Source/WebCore/platform/graphics/ImageBufferDisplayListBackend.h:
* Source/WebCore/platform/graphics/cg/ImageBufferCGPDFDocumentBackend.h:
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::getPixelBuffer):
(WebKit::RemoteImageBuffer::putPixelBuffer):
Originally-landed-as: 305413.751@safari-7624-branch (acb3c0834c1a).
rdar://180436488
Canonical link: https://commits.webkit.org/316326@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
