Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 74a12b6a1be8da6d70333bc4f407e49127205edf
https://github.com/WebKit/WebKit/commit/74a12b6a1be8da6d70333bc4f407e49127205edf
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-06 (Mon, 06 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-orientation-cone-gain-changes-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-orientation-cone-gain-changes.html
M Source/WebCore/Modules/webaudio/PannerNode.cpp
Log Message:
-----------
PannerNode orientation-only changes don't update the directional cone gain
https://bugs.webkit.org/show_bug.cgi?id=318619
rdar://181413407
Reviewed by Jean-Yves Avenard.
PannerNode::invalidateCachedPropertiesIfNecessary() stored position()
into m_lastOrientation instead of orientation(), so hasOrientationChanged
was computed as an alias of hasPositionChanged. As a result, rotating a
panner in place (changing orientation while leaving position unchanged)
never invalidated m_cachedConeGain, and the directional cone attenuation
stayed stale until some other property forced a recompute.
This only affects the cached (non sample-accurate) cone-gain path; the
sample-accurate path recomputes the cone gain every render quantum, so
the bug was masked whenever any panner or listener position/orientation
AudioParam was a-rate.
Fix the typo so orientation-only changes correctly drop the cached cone
gain.
Test:
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-orientation-cone-gain-changes.html
*
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-orientation-cone-gain-changes-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-orientation-cone-gain-changes.html:
Added.
* Source/WebCore/Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::invalidateCachedPropertiesIfNecessary):
Canonical link: https://commits.webkit.org/316541@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
