Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 842b183cf9826a4df6246e83e0ede733f03de195
https://github.com/WebKit/WebKit/commit/842b183cf9826a4df6246e83e0ede733f03de195
Author: Ryan Haddad <[email protected]>
Date: 2026-07-06 (Mon, 06 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] iOS-26-Simulator-WPT-WK2-Tests-EWS `run-layout-tests-without-change`
step ran all tests instead of only the failing ones
https://bugs.webkit.org/show_bug.cgi?id=317963
rdar://180755064
Reviewed by Aakash Jain.
The iOS WPT EWS builders scope themselves to running the tests in
`imported/w3c/web-platform-tests`
by passing along that path via `additionalArguments` in config.json. For the
`run-layout-tests-without-change` step we append `--skipped=always` plus the
subset of tests
that failed in the prior runs in order to only re-run those on the clean tree.
However, the
directory path contributed by `additionalArguments` was left on the command
line, so run-webkit-tests
ran the union of the whole directory and the subset, defeating the optimization
and running the full suite.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsWithoutChange.setLayoutTestCommand):
(RunWebKitTestsWithoutChange.positional_test_paths_from_additional_arguments):
Strip the
positional test paths that came from `additionalArguments` before appending the
failing subset,
while preserving flags such as `--child-processes` and
`--site-isolation-enabled-by-default`
as well as the value passed to `--exclude-tests`.
* Tools/CISupport/ews-build/steps_unittest.py: Add unit tests.
(TestRunWebKitTestsWithoutChange.test_run_subtest_tests_success):
(TestRunWebKitTestsWithoutChange):
(TestRunWebKitTestsWithoutChange.test_run_subtest_tests_strips_wpt_directory_from_additional_arguments):
(TestRunWebKitTestsWithoutChange.test_run_subtest_tests_preserves_flags_and_exclude_value):
Canonical link: https://commits.webkit.org/316566@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
