Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0181991daacad1d59eb2207a50070c8f487772bb
https://github.com/WebKit/WebKit/commit/0181991daacad1d59eb2207a50070c8f487772bb
Author: Ruthvik Konda <[email protected]>
Date: 2026-07-06 (Mon, 06 Jul 2026)
Changed paths:
A LayoutTests/ipc/create-audio-source-provider-twice-expected.txt
A LayoutTests/ipc/create-audio-source-provider-twice.html
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
Log Message:
-----------
RemoteMediaPlayerProxy::createAudioSourceProvider should reject duplicate IPC
https://bugs.webkit.org/show_bug.cgi?id=313571
rdar://175035393
Reviewed by Eric Carlson.
A well-behaved WebContent process sends CreateAudioSourceProvider at most once
per
RemoteMediaPlayerProxy. A second message reaches AudioSourceProviderAVFObjC's
setConfigureAudioStorageCallback / setAudioCallback, which overwrite the
callbacks
without taking tapStorage->lock while a MediaToolbox thread may be invoking them
under that lock, freeing the captured RemoteAudioSourceProviderProxy mid-use.
Reject the duplicate message with a MESSAGE_CHECK.
* LayoutTests/ipc/create-audio-source-provider-twice-expected.txt: Added.
* LayoutTests/ipc/create-audio-source-provider-twice.html: Added.
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::createAudioSourceProvider):
Originally-landed-as: 305413.810@safari-7624-branch (c5c267219314).
rdar://180429279
Canonical link: https://commits.webkit.org/316568@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
