Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 898be46c29af657b82dab5b773edffa86e31715e
https://github.com/WebKit/WebKit/commit/898be46c29af657b82dab5b773edffa86e31715e
Author: Alan Baradlay <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
[cleanup] Apply flex item cross-axis alignment in a single final pass
https://bugs.webkit.org/show_bug.cgi?id=318465
Reviewed by Antti Koivisto.
The cross-axis alignment steps (adjustAlignmentForFlexItem and
flipForRightToLeftColumn) each applied the flex item's new location to the
renderer as they went. Now that they compute onto item.flowAwareLocation, have
them just move the item, and flush every item's location to its renderer in one
pass at the end of performFlexLayout -- the legacy analog of
FlexLayout::computeFlexItemRects.
No change in behavior: item.flowAwareLocation is computed exactly as before,
only written to the renderer later, and nothing reads the renderer's location
between the alignment steps and the final flush. placeFlexItems and
layoutColumnReverse still apply eagerly, so the multi-line column re-layout in
distributeMainAxisFreeSpaceForMultilineColumnIfNeeded still sees each item at
its
placed location.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::performFlexLayout):
(WebCore::RenderFlexibleBox::adjustAlignmentForFlexItem):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
Canonical link: https://commits.webkit.org/316932@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
