Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db0ac8a9cb38503d756e987bddd865b0f3038fa5
https://github.com/WebKit/WebKit/commit/db0ac8a9cb38503d756e987bddd865b0f3038fa5
Author: shierote <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-override-descriptor-getter-setter.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSFontFaceDescriptors.cpp
M Source/WebCore/css/CSSFontFaceDescriptors.h
M Source/WebCore/css/CSSFontFaceDescriptors.idl
M Source/WebCore/css/CSSFontSelector.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/FontFace.cpp
M Source/WebCore/css/FontFace.h
M Source/WebCore/css/FontFace.idl
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h
Log Message:
-----------
Expose @font-face metric override descriptors through FontFace APIs
https://bugs.webkit.org/show_bug.cgi?id=219735
Reviewed by Tim Nguyen.
Expose ascent-override, descent-override, and line-gap-override through
FontFace and CSSFontFaceDescriptors behind the existing testable feature
flag. This is the API/storage step after parser support; metrics
application is intentionally left to a follow-up patch.
Tests:
imported/w3c/web-platform-tests/css/css-font-loading/fontface-override-descriptor-getter-setter.sub.html
imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https.html
imported/w3c/web-platform-tests/css/css-fonts/idlharness.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontface-override-descriptor-getter-setter.sub-expected.txt:
Update expectations for FontFace metric override descriptor getter/setter
coverage.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https-expected.txt:
Update expectations for the newly exposed FontFace IDL attributes.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt:
Update expectations for the newly exposed CSSFontFaceDescriptors IDL attributes.
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::CSSFontFace::setAscentOverride): Added.
(WebCore::CSSFontFace::setDescentOverride): Added.
(WebCore::CSSFontFace::setLineGapOverride): Added.
(WebCore::CSSFontFace::ascentOverride): Added.
(WebCore::CSSFontFace::descentOverride): Added.
(WebCore::CSSFontFace::lineGapOverride): Added.
* Source/WebCore/css/CSSFontFace.h:
Declare metric override descriptor accessors.
* Source/WebCore/css/CSSFontFaceDescriptors.cpp:
(WebCore::CSSFontFaceDescriptors::ascentOverride): Added.
(WebCore::CSSFontFaceDescriptors::setAscentOverride): Added.
(WebCore::CSSFontFaceDescriptors::descentOverride): Added.
(WebCore::CSSFontFaceDescriptors::setDescentOverride): Added.
(WebCore::CSSFontFaceDescriptors::lineGapOverride): Added.
(WebCore::CSSFontFaceDescriptors::setLineGapOverride): Added.
* Source/WebCore/css/CSSFontFaceDescriptors.h:
Declare metric override descriptor accessors.
* Source/WebCore/css/CSSFontFaceDescriptors.idl:
Expose metric override descriptors behind
CSSFontFaceMetricOverrideDescriptorsEnabled.
* Source/WebCore/css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Preserve parsed metric override
descriptors on CSSFontFace.
* Source/WebCore/css/CSSProperties.json:
Export generated parser entry points for the metric override descriptors.
* Source/WebCore/css/FontFace.cpp:
(WebCore::FontFace::create): Initialize metric override descriptors when the
testable flag is enabled.
(WebCore::FontFace::setAscentOverride): Added.
(WebCore::FontFace::setDescentOverride): Added.
(WebCore::FontFace::setLineGapOverride): Added.
(WebCore::FontFace::ascentOverride): Added.
(WebCore::FontFace::descentOverride): Added.
(WebCore::FontFace::lineGapOverride): Added.
* Source/WebCore/css/FontFace.h:
Add FontFace descriptor storage and accessors.
* Source/WebCore/css/FontFace.idl:
Expose FontFace descriptor dictionary members and attributes behind
CSSFontFaceMetricOverrideDescriptorsEnabled.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
(WebCore::CSSPropertyParserHelpers::parseFontFaceMetricOverride): Added.
(WebCore::CSSPropertyParserHelpers::parseFontFaceAscentOverride): Added.
(WebCore::CSSPropertyParserHelpers::parseFontFaceDescentOverride): Added.
(WebCore::CSSPropertyParserHelpers::parseFontFaceLineGapOverride): Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h:
Declare metric override descriptor parser helpers.
Canonical link: https://commits.webkit.org/316933@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
