Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cb7a261712e72393e153e80f34fb5828885610e3
https://github.com/WebKit/WebKit/commit/cb7a261712e72393e153e80f34fb5828885610e3
Author: Richard Robinson <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M Source/WebKit/SourcesCocoa.txt
A Source/WebKit/UIProcess/mac/PositionInformationManager.cpp
A Source/WebKit/UIProcess/mac/PositionInformationManager.h
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[AppKit Gestures] Refactor position information controlling logic out of
WKAppKitGestureController
https://bugs.webkit.org/show_bug.cgi?id=319470
rdar://182278712
Reviewed by Abrar Rahman Protyasha.
This makes things a lot more organized.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/mac/PositionInformationManager.cpp: Added.
(WebKit::PositionInformationManager::PositionInformationManager):
(WebKit::PositionInformationManager::~PositionInformationManager):
(WebKit::PositionInformationManager::doAfterUpdate):
(WebKit::PositionInformationManager::didChange):
(WebKit::PositionInformationManager::invalidate):
(WebKit::PositionInformationManager::reset):
(WebKit::PositionInformationManager::abandonOutstandingRequest):
(WebKit::PositionInformationManager::requestUpdate):
(WebKit::PositionInformationManager::currentIsValid const):
(WebKit::PositionInformationManager::currentIsApproximatelyValid const):
(WebKit::PositionInformationManager::hasValidOutstandingRequest const):
(WebKit::PositionInformationManager::invokeAndRemovePendingHandlers):
* Source/WebKit/UIProcess/mac/PositionInformationManager.h: Added.
(WebKit::PositionInformationManager::hasValidCurrentInformation const):
(WebKit::PositionInformationManager::currentInformation const):
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController initWithPage:viewImpl:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:shouldDeferGesturesForEventThatWillBeginAction:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:didEndActionWithEvent:]):
(-[WKAppKitGestureController didCommitLoadForMainFrame]):
(-[WKAppKitGestureController positionInformationDidChange:]):
(-[WKAppKitGestureController _secondaryClickShouldBeginAtLocation:]):
(-[WKAppKitGestureController
_positionInformationRequestIsValidAtLocation:withRadius:]):
(-[WKAppKitGestureController _dragPressShouldBeginAtLocation:]):
(-[WKAppKitGestureController _panShouldBeginAtLocation:]):
(-[WKAppKitGestureController reset]):
(-[WKAppKitGestureController _invalidateCurrentPositionInformation]): Deleted.
(-[WKAppKitGestureController requestAsynchronousPositionInformationUpdate:]):
Deleted.
(-[WKAppKitGestureController doAfterPositionInformationUpdate:forRequest:]):
Deleted.
(-[WKAppKitGestureController _currentPositionInformationIsValidForRequest:]):
Deleted.
(-[WKAppKitGestureController _hasValidOutstandingPositionInformationRequest:]):
Deleted.
(-[WKAppKitGestureController
_invokeAndRemovePendingHandlersValidForCurrentPositionInformation]): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/317279@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
