Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 47787efa0f7b00c022835d1ed3f03e70b42e1f43
https://github.com/WebKit/WebKit/commit/47787efa0f7b00c022835d1ed3f03e70b42e1f43
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
Log Message:
-----------
[run-benchmark][GTK][WPE] Add support for auto-entering container SDK when
running minibrowser
https://bugs.webkit.org/show_bug.cgi?id=319511
Reviewed by Adrian Perez de Castro.
When executing the script run-benchmark outside of the container SDK but with
the auto-entering mechanism enabled it happens that the script first sets a
temporal random homedir and then calls run-minibrowser script. Then the script
run-minibrowser tries to auto-enter into the container, but since it has been
started with a temporal random empty home it can't find the podman image, so
it has to re-download again the huge image on a temporal dir. And it has to
do that anytime is invoked because the homedir changes from one invocation
to the next one.
To avoid this problem we can auto-enter into the container in run-benchmark
before executing the script run-minibrowser. But we should do this only when
the browser to run is minibrowser-gtk or minibrowser-wpe. Otherwise we would be
entering into the container to execute browsers like chrome or firefox which
are not available in the container SDK.
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(start):
Canonical link: https://commits.webkit.org/317280@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
