Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7cc54396c4a2135e9f4b22369db8b99dd795443
https://github.com/WebKit/WebKit/commit/a7cc54396c4a2135e9f4b22369db8b99dd795443
Author: Ling Ho <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
Log Message:
-----------
[WKBI] Bugzilla comment for PR creation not added to radar
rdar://122142046
Reviewed by Ryan Haddad.
When `git-webkit pull-request` posts to the associated bug, it makes two
separate tracker writes: it assigns the issue to the current user, and then
adds a "Pull request: <url>" comment. When both land in the same clock second,
the comment's email notification can be silently dropped -- for Bugzilla,
BugMail::Send only mails comments whose creation_ts is strictly greater than
the bug's whole-second `lastdiffed`, and the assignee change just advanced
`lastdiffed` to that second. The comment is still recorded on the bug, but no
email is ever sent, so the WebKit Bug Importer never sees the pull-request link.
Wait out the current second between the assignee change and the comment so the
comment lands in a later second and its notification is always sent. The delay
only applies on the racy path (an assignee change actually happened and we are
about to post the comment to an open issue); the already-assigned, gardening,
and reopen paths are unchanged.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version to
7.0.4.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.add_comment_to_issue): Sleep 1.1s after an assignee change before
posting the pull-request comment so the two writes fall in different seconds.
Canonical link: https://commits.webkit.org/317883@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
