Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2e35f45980c66c3c13083b545aac8949bdad9752
https://github.com/WebKit/WebKit/commit/2e35f45980c66c3c13083b545aac8949bdad9752
Author: Ling Ho <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Tools/WebKitBot/src/WebKitBot.mjs
Log Message:
-----------
[webkitbot] Orphaned .git/index.lock wedges reverts and the periodic pull
https://bugs.webkit.org/show_bug.cgi?id=320219
rdar://183157526
Reviewed by Ryan Haddad.
git creates .git/index.lock (and sibling *.lock files) while an index-mutating
command runs and removes it on exit. If the git process is killed mid-operation
the lock is orphaned, and every subsequent git command run by
cleanUpWorkingCopy() fails with "Unable to create '.../index.lock': File exists"
(exit 128) -- wedging the bot so reverts and the periodic pull stop working
until the file is removed by hand.
Clear stale *.lock files at the start of cleanUpWorkingCopy(), before any git
command. This is safe because the AsyncTaskQueue serializes all work and each
git subprocess is awaited, so no bot-spawned git process is running at that
point.
* Tools/WebKitBot/src/WebKitBot.mjs:
(WebKitBot.prototype.clearStaleGitLocks): Added. Remove orphaned git lock files.
(WebKitBot.prototype.cleanUpWorkingCopy): Call clearStaleGitLocks() before
resetting.
Canonical link: https://commits.webkit.org/317899@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
