Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f98b3f2b9488e5917929305e79d87c820311792e
https://github.com/WebKit/WebKit/commit/f98b3f2b9488e5917929305e79d87c820311792e
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Tools/Scripts/filter-test-logs
Log Message:
-----------
[WKCI] filter-test-logs crashes on output that is not valid UTF-8, and loses
the tail of the log when the step is killed
https://bugs.webkit.org/show_bug.cgi?id=319698
Reviewed by Alexey Proskuryakov.
This patch introduces the following three improvements:
- Never crash on text that is not valid UTF-8. Test output can contain
garbage bytes from a crashing process, or lone unicode surrogates from WPT
tests that use intentionally malformed text. The problematic characters
are kept and written as visible escapes (for example \udcff) instead
of crashing or being dropped. This replaces the workaround from
300617@main, which only covered the layout filter and silently dropped
the problematic lines from the log.
- Open the log file line-buffered. If buildbot kills the step, the log
uploaded to S3 is now complete up to the last line received, instead
of losing whatever was sitting in the write buffer. The cost was
measured on Linux and Mac and it is negligible (well below 1 second
for a 30-minute layout test run producing 150k lines).
- Remove the duplicated code in the filter functions. The eight
functions were almost identical, differing only in which lines switch
the filter to print-everything mode and which lines are always
printed. They are replaced by a single function plus a table (FILTERS)
describing each filter with those two conditions. Adding a new filter
is now a couple of lines in the table.
* Tools/Scripts/filter-test-logs:
(parser):
(filter_logs):
(main):
(filter_jsc_tests): Deleted.
(filter_layout_tests): Deleted.
(filter_scan_build): Deleted.
(filter_webdriver_tests): Deleted.
(filter_test262): Deleted.
(filter_minibrowser_tests): Deleted.
(filter_swift): Deleted.
(filter_api_tests): Deleted.
Canonical link: https://commits.webkit.org/317900@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
