Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 1eb849cd467cf5dc5ad9b694ac9b06d38e967859
https://github.com/WebKit/WebKit/commit/1eb849cd467cf5dc5ad9b694ac9b06d38e967859
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
Cherry-pick 311591@main (68c43f3fd9ec).
https://bugs.webkit.org/show_bug.cgi?id=311694
[WPE][cross-toolchain-helper] determineArchitecture() in webkitdirs.pm
doesn't handle correctly the cross-toolchain-helper case.
https://bugs.webkit.org/show_bug.cgi?id=311694
Reviewed by Philippe Normand.
When using cross-toolchain-helper determineArchitecture() in webkitdirs.pm
fails
to correctly determine the target architecture.
The problem is that determineArchitecture() gets called before entering
into the
cross-target environment because the value of architecuture is needed to
resolve
the values of argumentsForConfiguration() which are passed when the
build-webkit
gets re-execed into the cross-target environment.
So at that moment it can't reliable obtain the target architecture, and
instead
it obtains the host one because the CC environment variable with the
cross-compiler
is still not set.
To fix this problem this patch detects this edge case and then calls the
cmake
binary from the cross-toolchain SDK which is configured to resolve the
target
architecture.
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
Canonical link: https://commits.webkit.org/311591@main
Canonical link: https://commits.webkit.org/305877.1038@webkitglib/2.52
Commit: 16640be16d31c4d70a9556cbdae5288c2dfc3b39
https://github.com/WebKit/WebKit/commit/16640be16d31c4d70a9556cbdae5288c2dfc3b39
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
Cherry-pick 313950@main (2959d7c8b288).
https://bugs.webkit.org/show_bug.cgi?id=315634
[WPE][cross-toolchain-helper] REGRESSION(311591@main): bitbake builds
toolchain during determineArchitecture() with no visible output
https://bugs.webkit.org/show_bug.cgi?id=315634
Reviewed by Carlos Alberto Lopez Perez.
determineArchitecture() runs `cmake --system-information` via
cross-toolchain-helper --cross-toolchain-run-cmd to learn the target
architecture, with stdout piped into perl. When the cross toolchain has
not yet been built, the helper transparently triggers a multi-hour
`bitbake -c populate_sdk` first, and all of its progress output
disappears into that pipe - the perl reader only keeps the single
CMAKE_SYSTEM_PROCESSOR line, so the user sees no output for hours.
Pre-call cross-toolchain-helper --build-toolchain with stdio inherited
from the parent so the bitbake output reaches the terminal. The
helper's build_toolchain() short-circuits when the toolchain already
exists, so this adds no measurable cost on subsequent runs.
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
Canonical link: https://commits.webkit.org/313950@main
Canonical link: https://commits.webkit.org/305877.1039@webkitglib/2.52
Commit: 6fc54bedd0aea441417fb380e948e32310aee94e
https://github.com/WebKit/WebKit/commit/6fc54bedd0aea441417fb380e948e32310aee94e
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitperl/FeatureList.pm
Log Message:
-----------
Cherry-pick 313986@main (b5a4cbb2ccc9).
https://bugs.webkit.org/show_bug.cgi?id=315565
[WPE][GTK] Warn in build-webkit when building Release without assertions
https://bugs.webkit.org/show_bug.cgi?id=315565
Reviewed by Justin Michaud.
The GTK and WPE EWS bots build and test with -DENABLE_ASSERTS=ON for
both Release and Debug, but the default developer build does not match
this configuration on Release (where the CMake default value disables
assertions). This mismatch means that issues caught by assertions on
the CI can go unnoticed when reproducing locally.
Rather than silently changing the default for everyone, surface the
mismatch more clearly so developers can opt in:
* Expose ENABLE_ASSERTS as a build-webkit feature option, so
--asserts / --no-asserts can be passed to enable or disable
assertions explicitly (translating into -DENABLE_ASSERTS=ON|OFF
for CMake-based builds).
* Print a one-line warning at CMake configure time when building
GTK or WPE without assertions enabled. On Release this warns
unless --asserts (or an equivalent -DENABLE_ASSERTS=ON) is
passed; on Debug it warns only when assertions have been
explicitly disabled via --no-asserts or -DENABLE_ASSERTS=OFF.
* Tools/Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
* Tools/Scripts/webkitperl/FeatureList.pm:
Canonical link: https://commits.webkit.org/313986@main
Canonical link: https://commits.webkit.org/305877.1040@webkitglib/2.52
Commit: f25e85f2e3a857b57c095959be85161870f77bb8
https://github.com/WebKit/WebKit/commit/f25e85f2e3a857b57c095959be85161870f77bb8
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Tools/Scripts/cross-toolchain-helper
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
Cherry-pick 314131@main (778e858024a4).
https://bugs.webkit.org/show_bug.cgi?id=315783
[WPE][cross-toolchain-helper] REGRESSION(313950@main)
REGRESSION(313986@main): repeated info messages and wrong warning when building
WebKit
https://bugs.webkit.org/show_bug.cgi?id=315783
Reviewed by Nikolas Zimmermann.
After 313950@main cross-toolchain-helper is called twice with output stdout
(not captured) and each time it gets executed it prints several info
messages,
so it ends printing those info messages twice.
Fix that by suppressing the info messages on the first run.
And also fix a bug in the logger level of cross-toolchain-helper, because
"quiet" was not working.
After 313986@main when doing a cross-toolchain-helper it printed this:
WARNING: Building Release_rpi4-64bits-mesa. This is not tested on the CI.
That is wrong, so fix it also.
* Tools/Scripts/cross-toolchain-helper:
(configure_logging):
(YoctoCrossBuilder.cross_dev_shell):
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
(generateBuildSystemFromCMakeProject):
Canonical link: https://commits.webkit.org/314131@main
Canonical link: https://commits.webkit.org/305877.1041@webkitglib/2.52
Commit: 0e9b63f0ca874fb42472d499e862a27c4b5b2c2b
https://github.com/WebKit/WebKit/commit/0e9b63f0ca874fb42472d499e862a27c4b5b2c2b
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
Cherry-pick 314136@main (f1c9e4d06275).
https://bugs.webkit.org/show_bug.cgi?id=315783
[WPE][cross-toolchain-helper] REGRESSION(313950@main): repeated info
messages and wrong warning when building webkit (v2)
https://bugs.webkit.org/show_bug.cgi?id=315783
Unreviewed follow-up patch.
314131@main made quiet the call to build the cross-toolchain and left
verbose
the one to execute build-webkit inside the environment, but is better to do
the other way around. Because the one to build the toolchain happens first,
so it is less confusing to print the log messages at the start of the build
rather than in the middle (which happens when the toolchain is not built or
is invalidated by a config change)
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
(runInCrossTargetEnvironment):
Canonical link: https://commits.webkit.org/314136@main
Canonical link: https://commits.webkit.org/305877.1042@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/3fa7d802a968...0e9b63f0ca87
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
