Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 37462ea769c050630fac0d302a401c873a3a3074
https://github.com/WebKit/WebKit/commit/37462ea769c050630fac0d302a401c873a3a3074
Author: Richard Robinson <[email protected]>
Date: 2026-08-05 (Wed, 05 Aug 2026)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.h
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
Log Message:
-----------
[AppKit Gestures] Simplify WKAppKitGestureController.mm a bit
https://bugs.webkit.org/show_bug.cgi?id=321019
rdar://184055828
Reviewed by Abrar Rahman Protyasha.
- Remove a few unused variables
- Use a single source of truth by keeping a single reference to the WKWebView,
to avoid duplication
and redundant null checks.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.h:
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController initWithView:]):
(-[WKAppKitGestureController initialize]):
(-[WKAppKitGestureController webView]):
(-[WKAppKitGestureController addGesturesToWebView]):
(-[WKAppKitGestureController enableGestureIfNeeded:]):
(-[WKAppKitGestureController
beginSuppressingSingleClickGestureForTextSelection]):
(-[WKAppKitGestureController endSuppressingSingleClickGestureForTextSelection]):
(-[WKAppKitGestureController panGestureRecognized:]):
(-[WKAppKitGestureController singleClickGestureRecognized:]):
(-[WKAppKitGestureController doubleClickGestureRecognized:]):
(-[WKAppKitGestureController secondaryClickGestureRecognized:]):
(-[WKAppKitGestureController mouseTrackingGestureRecognized:]):
(-[WKAppKitGestureController imageAnalysisGestureRecognized:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:shouldDeferGesturesForEventThatWillBeginAction:]):
(-[WKAppKitGestureController
deferringGestureRecognizer:didEndActionWithEvent:]):
(-[WKAppKitGestureController _isPointInScrollbar:]):
(-[WKAppKitGestureController _dragPressShouldBeginAtLocation:]):
(-[WKAppKitGestureController _panShouldBeginAtLocation:]):
(-[WKAppKitGestureController dragPressGestureRecognized:]):
(-[WKAppKitGestureController _handleClickBegan:]):
(-[WKAppKitGestureController _handleClickEnded:]):
(-[WKAppKitGestureController _handleClickCancelled]):
(-[WKAppKitGestureController
didGetClickHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]):
(-[WKAppKitGestureController commitPotentialClickFailed]):
(-[WKAppKitGestureController didCompleteSyntheticClick]):
(-[WKAppKitGestureController didHandleClickAsHover]):
(-[WKAppKitGestureController didNotHandleClickAsClick:]):
(-[WKAppKitGestureController sendWheelEventForGesture:]):
(-[WKAppKitGestureController startMomentumIfNeededForGesture:]):
(-[WKAppKitGestureController interruptMomentumIfNeeded]):
(-[WKAppKitGestureController setTextSelectionDragGesture:completionHandler:]):
(-[WKAppKitGestureController setGestureDraggingSession:]):
(-[WKAppKitGestureController
gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKAppKitGestureController
gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]):
(-[WKAppKitGestureController
gestureRecognizer:shouldRequireFailureOfGestureRecognizer:]):
(-[WKAppKitGestureController gestureRecognizerShouldBegin:]):
(-[WKAppKitGestureController _gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKAppKitGestureController initWithPage:viewImpl:]): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::m_flagsChangedEventMonitorTrackingArea):
(WebKit::WebViewImpl::initializeAppKitGestureController):
Canonical link: https://commits.webkit.org/318688@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
