Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f86c27b74cf2a1ad2c8d2b2b10e83892c302dfa
      
https://github.com/WebKit/WebKit/commit/1f86c27b74cf2a1ad2c8d2b2b10e83892c302dfa
  Author: Karl Dubost <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-002-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-002.html

  Log Message:
  -----------
  [css-writing-modes] Add WPT coverage for orthogonal atomic inline children of 
shrink-to-fit boxes
https://bugs.webkit.org/show_bug.cgi?id=187454
rdar://41980917

Reviewed by Brent Fulgham.

The round language selector button in this bug no longer paints as a narrow
oval. 317781@main fixed it, so this change is tests only.

The page puts an atomic inline (display:inline-block) in vertical-lr inside a
shrink-to-fit inline-block label. The vertical child's horizontal extent is its
block axis size, and the label has to use that as the child's inline size
contribution. Before 317781@main an orthogonal child that had not been laid out
yet contributed only its border and padding, so the label collapsed to its own
0.5em of padding and the border-radius:50% background painted narrower than the
text inside it.

orthogonal-parent-shrink-to-fit-001.html already covers orthogonal block and
orthogonal inline children, but not an orthogonal atomic inline, which goes
through RenderBlockFlow::computeInlineIntrinsicLogicalWidths instead of
RenderBlock::computeBlockIntrinsicLogicalWidths. A regression limited to the
inline path would leave 001 passing. This is a sibling file rather than extra
subtests in 001, because 001's subtests are already mirrored one per file across
001a to 001x and the letter suffixes are used up.

12 subtests: inline-block, float and table-cell shrink-to-fit parents, each with
and without a border on the child, each with the child direct and nested in an
inline-block. Also checked against Safari Technology Preview 249, which predates
317781@main: all 12 fail there, the parent measuring 0px, or 10px with the 0.5em
border, against a 20px child. All 12 pass on trunk.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-002.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/orthogonal-parent-shrink-to-fit-002-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/318689@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to