Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9491626d08e2e8354ab63d180874f9f27bfe4dc5
      
https://github.com/WebKit/WebKit/commit/9491626d08e2e8354ab63d180874f9f27bfe4dc5
  Author: Sammy Gill <[email protected]>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end-column-auto-flow-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end-column-auto-flow.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end-item-spans-multiple-rows-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end-item-spans-multiple-rows.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-end.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-start-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-block-start.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-end-columns-added-to-end-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-end-columns-added-to-end.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-end-items-in-last-column-trimmed-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-end-items-in-last-column-trimmed.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-start-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-start-item-negative-span-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-start-item-negative-span.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/computed-margin-values/grid-inline-start.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block-end-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block-end.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block-start-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block-start.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-block.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline-end-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline-end.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline-start-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline-start.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-inline.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-trim-ignores-collapsed-tracks-expected.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-box/margin-trim/grid-trim-ignores-collapsed-tracks.html
    M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
    M Source/WebCore/rendering/Grid.cpp
    M Source/WebCore/rendering/Grid.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  [Grid] margin-trim does not apply to grids.
https://bugs.webkit.org/show_bug.cgi?id=321130
rdar://problem/184164505

Reviewed by Alan Baradlay.

The CSSWG resolved that margin-trim will not apply to grid or flex
containers in https://github.com/w3c/csswg-drafts/issues/13731

Remove the code and tests associated with margin-trim on grid.

* Source/WebCore/rendering/Grid.cpp:
(WebCore::Grid::gridItemSpanIgnoringCollapsedTracks const): Deleted.
This function was unused after this so it get be deleted too.

Canonical link: https://commits.webkit.org/318690@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to