Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: be49eaa31fa4b97d4d39adafa618a3ab9ec5162e
https://github.com/WebKit/WebKit/commit/be49eaa31fa4b97d4d39adafa618a3ab9ec5162e
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableCell.cpp
Log Message:
-----------
Convert SkipEmptySectionsValue to a scoped enum class
https://bugs.webkit.org/show_bug.cgi?id=321901
rdar://185077973
Reviewed by Alan Baradlay.
Replace the unscoped `enum SkipEmptySectionsValue { DoNotSkipEmptySections,
SkipEmptySections }` in RenderTable.h with `enum class SkipEmptySections : bool
{ No, Yes }`, so the enumerators no longer leak into the WebCore namespace and
the underlying type is explicit.
The only clients are RenderTable itself and RenderTableCell's collapsed-border
computation, so all fifteen references are updated here; no behavior change.
Also drop a stray double space in one of the comparisons in sectionBelow().
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::topNonEmptySection const):
(WebCore::RenderTable::bottomNonEmptySection const):
(WebCore::RenderTable::sectionAbove const):
(WebCore::RenderTable::sectionBelow const):
(WebCore::RenderTable::cellAbove const):
(WebCore::RenderTable::cellBelow const):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedBeforeBorder const):
(WebCore::RenderTableCell::computeCollapsedAfterBorder const):
Canonical link: https://commits.webkit.org/319315@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications