Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b2d705682005c60ac866d2dced440a9bc1458d5
https://github.com/WebKit/WebKit/commit/3b2d705682005c60ac866d2dced440a9bc1458d5
Author: Sam Sneddon <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py
M
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py
Log Message:
-----------
git-webkit install-hooks is failing - AttributeError: 'IdentifierTrailer'
object has no attribute 'split'
https://bugs.webkit.org/show_bug.cgi?id=321968
rdar://185152046
Unreviewed infrastructure fix.
This regressed in 319313@main (761e61f4ad96), from bug 316952.
We didn't udpate webkitscmpy.program.install_hooks for the change of
API, and we don't have Python type checking to have caught this.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
(InstallHooks.main):
*
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py:
(TestInstallHooks.write_hook):
(TestInstallHooks.test_install_hook_with_identifier_trailer):
Canonical link: https://commits.webkit.org/319316@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
