Title: [115597] trunk
- Revision
- 115597
- Author
- [email protected]
- Date
- 2012-04-29 08:25:13 -0700 (Sun, 29 Apr 2012)
Log Message
[GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=85131
Patch by Sudarsana Nagineni <[email protected]> on 2012-04-29
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add support for setDomainRelaxationForbiddenForURLScheme which allow
disabling domain relaxation.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Add missing implementation setDomainRelaxationForbiddenForURLScheme to
GTK's LayoutTestController.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
LayoutTests:
Unskip http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
* platform/gtk/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115596 => 115597)
--- trunk/LayoutTests/ChangeLog 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/LayoutTests/ChangeLog 2012-04-29 15:25:13 UTC (rev 115597)
@@ -1,3 +1,14 @@
+2012-04-29 Sudarsana Nagineni <[email protected]>
+
+ [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
+ https://bugs.webkit.org/show_bug.cgi?id=85131
+
+ Reviewed by Martin Robinson.
+
+ Unskip http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
+
+ * platform/gtk/test_expectations.txt:
+
2012-04-29 Zan Dobersek <[email protected]>
Unreviewed, gardening after revisions 115573 and 115582.
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (115596 => 115597)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-04-29 15:25:13 UTC (rev 115597)
@@ -789,9 +789,6 @@
// Requires willPerformClientRedirectToURL
BUGWK58526 : http/tests/loading/onload-vs-immediate-refresh.pl = FAIL
-// GTK+ does not have layoutTestController.setDomainRelaxationForbiddenForURLScheme
-BUGWKGTK : http/tests/security/setDomainRelaxationForbiddenForURLScheme.html = FAIL
-
// New failure after http://trac.webkit.org/changeset/53758
BUGWKGTK : scrollbars/scrollbar-middleclick-nopaste.html = FAIL
Modified: trunk/Source/WebKit/gtk/ChangeLog (115596 => 115597)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-04-29 15:25:13 UTC (rev 115597)
@@ -1,3 +1,18 @@
+2012-04-29 Sudarsana Nagineni <[email protected]>
+
+ [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
+ https://bugs.webkit.org/show_bug.cgi?id=85131
+
+ Reviewed by Martin Robinson.
+
+ Add support for setDomainRelaxationForbiddenForURLScheme which allow
+ disabling domain relaxation.
+
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+ (DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):
+ * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+ (DumpRenderTreeSupportGtk):
+
2012-04-22 Adrian Bunk <[email protected]>
[GTK] Remove the obsolete Hildon UI extensions
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (115596 => 115597)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-04-29 15:25:13 UTC (rev 115597)
@@ -56,6 +56,7 @@
#include "RenderListItem.h"
#include "RenderTreeAsText.h"
#include "RenderView.h"
+#include "SchemeRegistry.h"
#include "SecurityOrigin.h"
#include "SecurityPolicy.h"
#include "Settings.h"
@@ -905,3 +906,8 @@
WebKitMutationObserver::deliverAllMutations();
#endif
}
+
+void DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme(bool forbidden, const char* urlScheme)
+{
+ SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden, String::fromUTF8(urlScheme));
+}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (115596 => 115597)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2012-04-29 15:25:13 UTC (rev 115597)
@@ -127,6 +127,7 @@
static void setPageCacheSupportsPlugins(WebKitWebView*, bool enabled);
static void deliverAllMutationsIfNecessary();
+ static void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const char* urlScheme);
private:
static bool s_drtRun;
Modified: trunk/Tools/ChangeLog (115596 => 115597)
--- trunk/Tools/ChangeLog 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/Tools/ChangeLog 2012-04-29 15:25:13 UTC (rev 115597)
@@ -1,3 +1,16 @@
+2012-04-29 Sudarsana Nagineni <[email protected]>
+
+ [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
+ https://bugs.webkit.org/show_bug.cgi?id=85131
+
+ Reviewed by Martin Robinson.
+
+ Add missing implementation setDomainRelaxationForbiddenForURLScheme to
+ GTK's LayoutTestController.
+
+ * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+ (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
+
2012-04-28 Sam Weinig <[email protected]>
Smooth scrolling needs a new key
Modified: trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (115596 => 115597)
--- trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp 2012-04-29 15:20:12 UTC (rev 115596)
+++ trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp 2012-04-29 15:25:13 UTC (rev 115597)
@@ -741,9 +741,10 @@
// FIXME: implement
}
-void LayoutTestController::setDomainRelaxationForbiddenForURLScheme(bool, JSStringRef)
+void LayoutTestController::setDomainRelaxationForbiddenForURLScheme(bool forbidden, JSStringRef scheme)
{
- // FIXME: implement
+ GOwnPtr<gchar> urlScheme(JSStringCopyUTF8CString(scheme));
+ DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme(forbidden, urlScheme.get());
}
void LayoutTestController::goBack()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes