Title: [115598] trunk/PerformanceTests
Revision
115598
Author
[email protected]
Date
2012-04-29 11:22:22 -0700 (Sun, 29 Apr 2012)

Log Message

PerfTestRunner.computeStatistics incorrectly calculates min, max and median
https://bugs.webkit.org/show_bug.cgi?id=85111

Reviewed by Ryosuke Niwa.

The sort of the data input was being done alphabetically.
So I provided a numeric compare function.

* resources/runner.js:

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (115597 => 115598)


--- trunk/PerformanceTests/ChangeLog	2012-04-29 15:25:13 UTC (rev 115597)
+++ trunk/PerformanceTests/ChangeLog	2012-04-29 18:22:22 UTC (rev 115598)
@@ -1,3 +1,15 @@
+2012-04-29  Tom Zakrajsek  <[email protected]>
+
+        PerfTestRunner.computeStatistics incorrectly calculates min, max and median
+        https://bugs.webkit.org/show_bug.cgi?id=85111
+
+        Reviewed by Ryosuke Niwa.
+
+        The sort of the data input was being done alphabetically.
+        So I provided a numeric compare function.
+
+        * resources/runner.js:
+
 2012-04-17  Ilya Tikhonovsky  <[email protected]>
 
         Web Inspector: the fix for test after massive rename in r114271.

Modified: trunk/PerformanceTests/resources/runner.js (115597 => 115598)


--- trunk/PerformanceTests/resources/runner.js	2012-04-29 15:25:13 UTC (rev 115597)
+++ trunk/PerformanceTests/resources/runner.js	2012-04-29 18:22:22 UTC (rev 115598)
@@ -52,7 +52,7 @@
     var data = ""
 
     // Add values from the smallest to the largest to avoid the loss of significance
-    data.sort();
+    data.sort(function(a,b){return a-b;});
 
     var middle = Math.floor(data.length / 2);
     var result = {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to