Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0bcd5c84c365da592ed86a60c03e8e1aa011b51a
https://github.com/WebKit/WebKit/commit/0bcd5c84c365da592ed86a60c03e8e1aa011b51a
Author: Chris Dumez <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
A
LayoutTests/http/tests/webshare/shareddatareader-didfinishloading-crash-expected.txt
A
LayoutTests/http/tests/webshare/shareddatareader-didfinishloading-crash.html
M Source/WebCore/page/ShareDataReader.cpp
M Source/WebCore/page/ShareDataReader.h
Log Message:
-----------
[WebCore] use-after-free in ShareDataReader::didFinishLoading: cancel()
called on freed this after completionHandler destruction
https://bugs.webkit.org/show_bug.cgi?id=317270
rdar://177909918
Reviewed by Per Arne Vollan and Ben Nham.
Make sure we capture `weakThis` in the lambda instead of `this`, then
convert to a RefPtr before calling `didfinishLoading()` so that `this`
cannot be destroyed *while* running `didfinishLoading()`.
Test: http/tests/webshare/shareddatareader-didfinishloading-crash.html
*
LayoutTests/http/tests/webshare/shareddatareader-didfinishloading-crash-expected.txt:
Added.
* LayoutTests/http/tests/webshare/shareddatareader-didfinishloading-crash.html:
Added.
* Source/WebCore/page/ShareDataReader.cpp:
(WebCore::ShareDataReader::start):
* Source/WebCore/page/ShareDataReader.h:
Originally-landed-as: [email protected] (890fde552386).
rdar://185368266
Canonical link: https://commits.webkit.org/320367@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
