Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a01d26f0ddb26298bb95698e42c5ca37eec59235
https://github.com/WebKit/WebKit/commit/a01d26f0ddb26298bb95698e42c5ca37eec59235
Author: Brent Fulgham <[email protected]>
Date: 2026-09-02 (Wed, 02 Sep 2026)
Changed paths:
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-29-days-ago-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-29-days-ago.html
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-7-days-ago-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-7-days-ago.html
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-short-frequency-with-user-interaction-7-days-ago-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-short-frequency-with-user-interaction-7-days-ago.html
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-30-days-ago-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-30-days-ago.html
R
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt
R
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html
A
LayoutTests/http/tests/resourceLoadStatistics/resources/website-data-removal-checks.js
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/wk2/TestExpectations
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
Log Message:
-----------
De-flake some ITP test cases
https://bugs.webkit.org/show_bug.cgi?id=323136
rdar://186397129
Reviewed by Charlie Wolfe.
While investigating some other cookie bugs, I discovered that some ITP bugs had
an
ordering dependency that led to flaky behavior. This patch makes a few
improvements for
better coverage and to reduce flakiness:
1. Correct ResourceLoadStatisticsStore::resetParametersToDefaultValues so that
it clears
the minimumTimeBetweenDataRecordsRemoval along with other local state.
Several tests
worked around this by explicitly setting this to zero in their preambles,
but tests that
did not know to do this would become flaky if a long-removal test ran before
they did.
2. Renamed two tests to better match the test assertions.
3. Added three tests cover the Short/7 day, Long/29 day, and Long/30 day
windows.
4. Improves the website-data-removal-checks.js to prevent test results from
producing
similar output for distinct failure modes (e.g., it produced the same string
for a
success case AND a timeout case).
5. Corrected a bug in website-data-removal-checks.js that used indexedDB.open()
to test
for IndexedDB absence. This was bad because it caused a database to be
created, which
left a dangling connection that could persist for later tests. Instead, it
checks
using indexedDB.databases() which does not have this side-effect.
Tests:
http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-29-days-ago.html
http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-7-days-ago.html
http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-short-frequency-with-user-interaction-7-days-ago.html
http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-30-days-ago.html
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-29-days-ago-expected.txt:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-29-days-ago.html:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-7-days-ago-expected.txt:
Renamed from
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-7-days-ago.html:
Renamed from
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-short-frequency-with-user-interaction-7-days-ago-expected.txt:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-short-frequency-with-user-interaction-7-days-ago.html:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-30-days-ago-expected.txt:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-30-days-ago.html:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/resources/website-data-removal-checks.js:
Added.
(rdcAddOutput):
(rdcSleep):
(async rdcPollUntil):
(rdcLocalStorageNetworkView):
(rdcLocalStorageWebView):
(async rdcCheckLocalStorage):
(async rdcCookieNamesSeenByServer):
(rdcCookieNamesSeenByWebProcess):
(async if):
(const.present.async includes):
(async rdcCheckCookie):
(async rdcIDBExists):
(async rdcCheckIDB):
(async rdcCreateIDBAndClose):
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wk2/TestExpectations:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::resetParametersToDefaultValues):
Canonical link: https://commits.webkit.org/320369@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
