Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5204a1a34fa4baaf679a4f39ae0895f393fae67a
https://github.com/WebKit/WebKit/commit/5204a1a34fa4baaf679a4f39ae0895f393fae67a
Author: Alan Baradlay <[email protected]>
Date: 2026-09-04 (Fri, 04 Sep 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks.html
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
M
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
M
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.h
Log Message:
-----------
REGRESSION (Safari 27): line-height quirk not applied inside inline-block
https://bugs.webkit.org/show_bug.cgi?id=323287
<rdar://problem/186614663>
Reviewed by Antti Koivisto.
In quirks mode the line-height quirk applies to line break boxes too, since a
<br> has no text content.
310839@main made a <br> with a non-normal line-height stretch the line box
unconditionally, so a line-height
inherited from an ancestor started stretching lines that have other content on
them. Now the <br> only
stretches the line box when there's nothing else on the line to do it.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/br-line-height-inherited-quirks.html:
Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::inlineLevelBoxAffectsLineBox const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
*
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition
const):
(WebCore::Layout::LineBoxVerticalAligner::layoutBoundsForInlineBoxSubtree
const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):
*
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp:
(WebCore::Layout::InlineQuirks::lineBreakBoxIsOnlyContentOnLine):
(WebCore::Layout::InlineQuirks::lineBreakBoxAffectsParentInlineBox):
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.h:
Canonical link: https://commits.webkit.org/320514@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
