Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ebaa3acb4ca036ced8011e8bfb2e951dd2199696
https://github.com/WebKit/WebKit/commit/ebaa3acb4ca036ced8011e8bfb2e951dd2199696
Author: Cameron McCormack <[email protected]>
Date: 2026-09-24 (Thu, 24 Sep 2026)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
M Tools/WebKitTestRunner/PlatformWebView.h
M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
Log Message:
-----------
Wait for the window to be rendered before capturing a test snapshot
https://bugs.webkit.org/show_bug.cgi?id=324996
rdar://188205287
Reviewed by Matt Woodrow.
Sometimes layout tests fail because one of the two images a test
generates is blank.
CGWindowListCreateImage() composites the window's current content without
waiting for the render server to have drawn it: for a window-list capture the
window server schedules the capture pass immediately, and the synchronization
inside SLWindowListCreateImage() only waits on SkyLight transactions, which
CoreAnimation does not create.
* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
* Tools/WebKitTestRunner/PlatformWebView.h:
* Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::waitForWindowRendering):
(WTR::PlatformWebView::windowSnapshotImage):
Canonical link: https://commits.webkit.org/321795@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
