Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4611b6490697ed4378bf755412d55e906cd3d1cb
https://github.com/WebKit/WebKit/commit/4611b6490697ed4378bf755412d55e906cd3d1cb
Author: Ahmad Saleem <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformCocoa.cmake
Log Message:
-----------
[CMake] Duplicate symbol _OBJC_CLASS_$_WebProcessPlugInWithInternals linking
TestWebKitAPI on Cocoa
https://bugs.webkit.org/show_bug.cgi?id=325997
rdar://188943852
Reviewed by Zak Ridouh.
Two independent fixes for the "TestWebKitAPI is missing
WebProcessPlugInWithInternals" build break landed the same day and
collided. Bug 325873 (3ef653f1692f) added the source to
TestWebKit_SOURCES, while bug 325867 (ee0642ee2035) added it to the
TestWebKitAPILibrary OBJECT library. Because TestWebKit links that
OBJECT library's objects directly, WebProcessPlugInWithInternals.mm is
compiled into the executable twice, so the link fails with a duplicate
_OBJC_CLASS_$_ / _OBJC_METACLASS_$_WebProcessPlugInWithInternals.
Keep the TestWebKitAPILibrary membership, which is self-contained (it
also declares the WebCoreTestSupport link dependency the file needs and
sits next to WebPageConfiguration+Extras.swift, which references the
class), and drop the now-redundant TestWebKit_SOURCES entry.
* Tools/TestWebKitAPI/PlatformCocoa.cmake:
Remove WebProcessPlugInWithInternals.mm from TestWebKit_SOURCES; it is
already built via the TestWebKitAPILibrary OBJECT library that TestWebKit
links.
Canonical link: https://commits.webkit.org/322436@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
