Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e2016889f4e4dfab7eaf9a8c002553ed95e2806c
https://github.com/WebKit/WebKit/commit/e2016889f4e4dfab7eaf9a8c002553ed95e2806c
Author: Richard Robinson <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WKTextSelectionController.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Context menu is unexpectedly invoked
https://bugs.webkit.org/show_bug.cgi?id=326035
rdar://188026051
Reviewed by Abrar Rahman Protyasha.
The text selection manager presents the context menu when clicking on an
insertion point, which is
only expected for a visible caret, so don't report caret selections in
non-editable content.
Test: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
* Source/WebKit/UIProcess/mac/WKTextSelectionController.swift:
(WKTextSelectionController.selectionIsInsertionPoint):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
(AppKitGesturesTests.clickingTwiceAtCaretInEditableContentOpensContextMenu):
(AppKitGesturesTests.clickingTwiceAtCaretInNonEditableContentDoesNotOpenContextMenu(_:)):
Canonical link: https://commits.webkit.org/322458@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
