Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e4b84cf548cfaa58b906f9709b96c382821f3154
https://github.com/WebKit/WebKit/commit/e4b84cf548cfaa58b906f9709b96c382821f3154
Author: Alex Christensen <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.h
M Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaSession.mm
Log Message:
-----------
RemoteCommandListenerCocoa::updateSupportedCommands should only early return
if commands and seeking are both unchanged
https://bugs.webkit.org/show_bug.cgi?id=326021
rdar://187027159
Reviewed by Eric Carlson.
With site isolation enabled, the RemoteCommandListenerCocoa is created in the
GPU process earlier than
with site isolation disabled, and this results in it updating supported
commands before and after it learns
whether seeking is supported. Since supportsSeeking() is also an input into
what commands are sent,
make the early return require that supportsSeeking() has also not changed since
the last update.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaSession.mm
* Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.h:
* Source/WebCore/platform/cocoa/RemoteCommandListenerCocoa.mm:
(WebCore::RemoteCommandListenerCocoa::updateSupportedCommands):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaSession.mm:
(TestWebKitAPI::MediaSessionTest::siteIsolationEnabled const):
(TestWebKitAPI::TEST_F(MediaSessionSiteIsolationTest,
SeekCommandsRegisteredAfterSupportsSeekingChanges)):
Canonical link: https://commits.webkit.org/322536@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
