Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dca9bb82f6af2f8c0a16956c91c7c0ef6718825a
https://github.com/WebKit/WebKit/commit/dca9bb82f6af2f8c0a16956c91c7c0ef6718825a
Author: Alex Christensen <[email protected]>
Date: 2026-10-03 (Sat, 03 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
Stop using FrameInfoData for back/forward site isolation testing
https://bugs.webkit.org/show_bug.cgi?id=326152
rdar://189047491
Reviewed by Basuke Suzuki.
WebPage::getFrameTreeForBackForwardCacheEntry created a FrameInfoData and even
wrapped
it in a FrameTreeNodeData without using any values except the main frame URL.
Stop using these structures I'm trying to simplify in a place they're not
needed.
Use a URL instead.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _frameTreesInBackForwardCacheAtIndex:completionHandler:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView
_topDocumentURLsInBackForwardCacheAtIndexForTesting:completionHandler:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getBackForwardCacheEntryTopDocumentURLsForTesting):
(WebKit::WebPageProxy::getFrameTreesForBackForwardItem): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getBackForwardCacheEntryTopDocumentURL):
(WebKit::WebPage::getFrameTreeForBackForwardCacheEntry): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::checkTopDocumentURLsInBackForwardCacheAtIndex):
(TestWebKitAPI::TEST(SiteIsolation, BFCacheSameSitePageChangesTopDocumentURL)):
(TestWebKitAPI::TEST(SiteIsolation, BFCacheCrossSitePageKeepsTopDocumentURL)):
(TestWebKitAPI::frameTreesInBackForwardCacheAtIndex): Deleted.
Canonical link: https://commits.webkit.org/322611@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
