Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2c56275caa257433ef450da20bec63584c1aa447
https://github.com/WebKit/WebKit/commit/2c56275caa257433ef450da20bec63584c1aa447
Author: Tyler Wilcock <[email protected]>
Date: 2026-10-03 (Sat, 03 Oct 2026)
Changed paths:
M
LayoutTests/accessibility/isolated-tree/mac/detected-form-error-key-press-that-does-not-submit-expected.txt
M
LayoutTests/accessibility/isolated-tree/mac/detected-form-error-key-press-that-does-not-submit.html
M
LayoutTests/accessibility/mac/detected-form-error-key-press-that-does-not-submit-expected.txt
M
LayoutTests/accessibility/mac/detected-form-error-key-press-that-does-not-submit.html
M Source/WebCore/accessibility/AXObjectCache.cpp
Log Message:
-----------
AX Error Detection: Pressing Enter in a dropdown's search box starts a watch
for form errors
https://bugs.webkit.org/show_bug.cgi?id=326209
rdar://189093707
Reviewed by Chris Fleizach.
Enter in a text field starts a watch for form errors unless the field offers
suggestions, since there
Enter picks one rather than submitting anything. Only the field's own role,
list and aria-autocomplete
were checked, but dropdowns a page builds itself, such as vue-multiselect and
Select2 libraries, put the combobox
role on an element around their search box. Choosing an option with Enter then
counted as an attempt to
submit the form, which is not correct behavior. Also treat a field inside an
element with the combobox role
as offering suggestions.
*
LayoutTests/accessibility/isolated-tree/mac/detected-form-error-key-press-that-does-not-submit-expected.txt:
*
LayoutTests/accessibility/isolated-tree/mac/detected-form-error-key-press-that-does-not-submit.html:
*
LayoutTests/accessibility/mac/detected-form-error-key-press-that-does-not-submit-expected.txt:
*
LayoutTests/accessibility/mac/detected-form-error-key-press-that-does-not-submit.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::offersSuggestions):
Canonical link: https://commits.webkit.org/322622@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
