Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b2c6aff313650b38ff032320d4ac2e2531f7e6e
https://github.com/WebKit/WebKit/commit/1b2c6aff313650b38ff032320d4ac2e2531f7e6e
Author: Tyler Wilcock <[email protected]>
Date: 2026-10-03 (Sat, 03 Oct 2026)
Changed paths:
A
LayoutTests/accessibility/detected-form-error-status-rewritten-as-error-expected.txt
A
LayoutTests/accessibility/detected-form-error-status-rewritten-as-error.html
A
LayoutTests/accessibility/isolated-tree/detected-form-error-status-rewritten-as-error-expected.txt
A
LayoutTests/accessibility/isolated-tree/detected-form-error-status-rewritten-as-error.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AXFormActivityMonitor.cpp
M Source/WebCore/accessibility/AXFormActivityMonitor.h
Log Message:
-----------
AX Error Detection: An error message the page rewrites is announced with its
old wording
https://bugs.webkit.org/show_bug.cgi?id=326215
rdar://189097660
Reviewed by Chris Fleizach.
Pages often reuse one element for a status and then the error, so it says
"Signing in" and then
"Incorrect password." A message's wording and color were captured when it first
appeared and kept
when the same element came back with new wording, so VoiceOver announced
"Signing in". After a
possible submission, a status that turned red was still judged by the color it
started in, and dropped.
Read each message's wording and color when the page settles instead. Wording
that still contains
what was collected is kept, since text that arrives on its own can be part of
what its element says.
*
LayoutTests/accessibility/detected-form-error-status-rewritten-as-error-expected.txt:
Added.
* LayoutTests/accessibility/detected-form-error-status-rewritten-as-error.html:
Added.
*
LayoutTests/accessibility/isolated-tree/detected-form-error-status-rewritten-as-error-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/detected-form-error-status-rewritten-as-error.html:
Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/accessibility/AXFormActivityMonitor.cpp:
(WebCore::AXFormActivityMonitor::collectErrorMessagesFrom):
(WebCore::AXFormActivityMonitor::report):
* Source/WebCore/accessibility/AXFormActivityMonitor.h:
Canonical link: https://commits.webkit.org/322621@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
